diff options
| author | Fabian Wolff <fabian.wolff@alumni.ethz.ch> | 2022-01-18 19:19:23 +0100 |
|---|---|---|
| committer | Fabian Wolff <fabian.wolff@alumni.ethz.ch> | 2022-01-18 21:08:59 +0100 |
| commit | f7b7138a62648f4019c55e4671682af1f851f295 (patch) | |
| tree | 80f48510a7f03c8125226540efb4134627961509 /lldb/source/Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h | |
| parent | 7ac65f6b2e961d3eda547b50eefdab8a04d819fd (diff) | |
| download | llvm-f7b7138a62648f4019c55e4671682af1f851f295.zip llvm-f7b7138a62648f4019c55e4671682af1f851f295.tar.gz llvm-f7b7138a62648f4019c55e4671682af1f851f295.tar.bz2 | |
[clang-tidy] Make `readability-container-data-pointer` more robust
Fixes PR#52245. I've also added a few test cases beyond PR#52245 that would also fail with the current implementation, which is quite brittle in many respects (e.g. it uses the `hasDescendant()` matcher to find the container that is being accessed, which is very easy to trick, as in the example in PR#52245).
I have not been able to reproduce the second issue mentioned in PR#52245 (namely that using the `data()` member function is suggested even for containers that don't have it), but I've added a test case for it to be sure.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D113863
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h')
0 files changed, 0 insertions, 0 deletions