diff options
author | Hans Wennborg <hans@chromium.org> | 2022-03-04 17:25:48 +0100 |
---|---|---|
committer | Hans Wennborg <hans@chromium.org> | 2022-03-04 17:36:26 +0100 |
commit | 85c53c7092176e5f611fe620867eb2b82a30c80d (patch) | |
tree | cfbc5e12e51e923c90e17a0794a5a9de7ad2019b /lldb/source/Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h | |
parent | 7a605ab7bfbc681c34335684f45b7da32d495db1 (diff) | |
download | llvm-85c53c7092176e5f611fe620867eb2b82a30c80d.zip llvm-85c53c7092176e5f611fe620867eb2b82a30c80d.tar.gz llvm-85c53c7092176e5f611fe620867eb2b82a30c80d.tar.bz2 |
Revert "[AArch64] Async unwind - function prologues"
It caused builds to assert with:
(StackSize == 0 && "We already have the CFA offset!"),
function generateCompactUnwindEncoding, file AArch64AsmBackend.cpp, line 624.
when targeting iOS. See comment on the code review for reproducer.
> This patch rearranges emission of CFI instructions, so the resulting
> DWARF and `.eh_frame` information is precise at every instruction.
>
> The current state is that the unwind info is emitted only after the
> function prologue. This is fine for synchronous (e.g. C++) exceptions,
> but the information is generally incorrect when the program counter is
> at an instruction in the prologue or the epilogue, for example:
>
> ```
> stp x29, x30, [sp, #-16]! // 16-byte Folded Spill
> mov x29, sp
> .cfi_def_cfa w29, 16
> ...
> ```
>
> after the `stp` is executed the (initial) rule for the CFA still says
> the CFA is in the `sp`, even though it's already offset by 16 bytes
>
> A correct unwind info could look like:
> ```
> stp x29, x30, [sp, #-16]! // 16-byte Folded Spill
> .cfi_def_cfa_offset 16
> mov x29, sp
> .cfi_def_cfa w29, 16
> ...
> ```
>
> Having this information precise up to an instruction is useful for
> sampling profilers that would like to get a stack backtrace. The end
> goal (towards this patch is just a step) is to have fully working
> `-fasynchronous-unwind-tables`.
>
> Reviewed By: danielkiss, MaskRay
>
> Differential Revision: https://reviews.llvm.org/D111411
This reverts commit 32e8b550e5439c7e4aafa73894faffd5f25d0d05.
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h')
0 files changed, 0 insertions, 0 deletions