diff options
| author | Michael Buch <michaelbuch12@gmail.com> | 2024-10-29 18:40:06 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-29 18:40:06 +0000 |
| commit | b4e1af0096fd05ed4bddf11b48b604d75a7103d0 (patch) | |
| tree | e4baf014000af89518c02c4634630c3f92c5b5ef /lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp | |
| parent | efc6d33be9f4b4d0f0e8d3d5f198f2616b75792b (diff) | |
| download | llvm-b4e1af0096fd05ed4bddf11b48b604d75a7103d0.zip llvm-b4e1af0096fd05ed4bddf11b48b604d75a7103d0.tar.gz llvm-b4e1af0096fd05ed4bddf11b48b604d75a7103d0.tar.bz2 | |
[lldb-dap] Always pass disableASLR to the DAP executable (#113891)
More context can be found in
https://github.com/llvm/llvm-project/pull/110303
For DAP tests running in constrained environments (e.g., Docker
containers), disabling ASLR isn't allowed. So we set `disableASLR=False`
(since https://github.com/llvm/llvm-project/pull/113593).
However, the `dap_server.py` will currently only forward the value
of `disableASLR` to the DAP executable if it's set to `True`. If the
DAP executable wasn't provided a `disableASLR` field it defaults to
`true` too:
https://github.com/llvm/llvm-project/blob/f14743794587db102c6d1b20f9c87a1ac20decfd/lldb/tools/lldb-dap/lldb-dap.cpp#L2103-L2104
This means that passing `disableASLR=False` from the tests is currently
not possible.
This is also true for many of the other boolean arguments of
`request_launch`. But this patch only addresses `disableASLR` for now
since it's blocking a libc++ patch.
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp')
0 files changed, 0 insertions, 0 deletions