diff options
| author | Shoaib Meenai <smeenai@fb.com> | 2023-08-31 18:04:56 -0700 |
|---|---|---|
| committer | Shoaib Meenai <smeenai@fb.com> | 2023-09-18 16:14:18 -0700 |
| commit | 58288c6c1214f8a3a0e32e003406437652e098bd (patch) | |
| tree | 49ce1b6d09bf4f85111cf6b1ff44d18763decdd1 /lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp | |
| parent | 9a04bc4c43f7a0a556765869c49d9a10473b40f2 (diff) | |
| download | llvm-58288c6c1214f8a3a0e32e003406437652e098bd.zip llvm-58288c6c1214f8a3a0e32e003406437652e098bd.tar.gz llvm-58288c6c1214f8a3a0e32e003406437652e098bd.tar.bz2 | |
[driver] Search for compatible Android runtime directories
Android triples include a version number, which makes direct triple
comparisons for per-target runtime directory searching not always work.
Instead, look for the triple with the highest compatible version number
and use that per-target runtime directory instead. This maintains the
existing fallback to a triple without any version number, but I'm hoping
we can remove that in the future. https://discourse.llvm.org/t/62717
discusses this further.
The one remaining triple mismatch after this is that Android armv7
triples usually have an environment of `androideabi`, which Clang
normalizes to `android`. If you use the `androideabi` triple when
building the runtimes with a per-target runtimes dir, the directory will
get created with `androideabi` in its name, but Clang's triple search
uses the normalized triple and will look for an `android` directory
instead. https://reviews.llvm.org/D140925 will fix that by normalizing
triples when creating the per-target runtimes directories as well.
Reviewed By: phosek, pirama
Differential Revision: https://reviews.llvm.org/D158476
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp')
0 files changed, 0 insertions, 0 deletions