diff options
| author | Fangrui Song <i@maskray.me> | 2022-02-01 10:41:16 -0800 |
|---|---|---|
| committer | Fangrui Song <i@maskray.me> | 2022-02-01 10:41:16 -0800 |
| commit | 30e8f83c84c5a302a559722fc0d2973dc3f425ee (patch) | |
| tree | f6418fd0f942ce769a9503cec5069292ba74bed7 /lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp | |
| parent | a2361eb28160dc747b4f5a321faefb9c4cc15ba1 (diff) | |
| download | llvm-30e8f83c84c5a302a559722fc0d2973dc3f425ee.zip llvm-30e8f83c84c5a302a559722fc0d2973dc3f425ee.tar.gz llvm-30e8f83c84c5a302a559722fc0d2973dc3f425ee.tar.bz2 | |
[GlobalOpt] Don't replace alias with aliasee if either alias/aliasee may be preemptible
Generalize D99629 for ELF. A default visibility non-local symbol is preemptible
in a -shared link. `isInterposable` is an insufficient condition.
Moreover, a non-preemptible alias may be referenced in a sub constant expression
which intends to lower to a PC-relative relocation. Replacing the alias with a
preemptible aliasee may introduce a linker error.
Respect dso_preemptable and suppress optimization to fix the abose issues. With
the change, `alias = 345` will not be rewritten to use aliasee in a `-fpic`
compile.
```
int aliasee;
extern int alias __attribute__((alias("aliasee"), visibility("hidden")));
void foo() { alias = 345; } // intended to access the local copy
```
While here, refine the condition for the alias as well.
For some binary formats like COFF, `isInterposable` is a sufficient condition.
But I think canonicalization for the changed case has little advantage, so I
don't bother to add the `Triple(M.getTargetTriple()).isOSBinFormatELF()` or
`getPICLevel/getPIELevel` complexity.
For instrumentations, it's recommended not to create aliases that refer to
globals that have a weak linkage or is preemptible. However, the following is
supported and the IR needs to handle such cases.
```
int aliasee __attribute__((weak));
extern int alias __attribute__((alias("aliasee")));
```
There are other places where GlobalAlias isInterposable usage may need to be
fixed.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D107249
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp')
0 files changed, 0 insertions, 0 deletions
