aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp
diff options
context:
space:
mode:
authorLouis Dionne <ldionne.2@gmail.com>2021-10-04 15:01:27 -0400
committerLouis Dionne <ldionne.2@gmail.com>2021-10-07 17:27:24 -0400
commit1262f8a64d21ca0cfca81b2039809d14ae4691bc (patch)
treebd3e7362861e1dc43554ca4c8ac05cadaac70ec8 /lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp
parentc07b80ca536158a42d1557a10d892c09ccd1f268 (diff)
downloadllvm-1262f8a64d21ca0cfca81b2039809d14ae4691bc.zip
llvm-1262f8a64d21ca0cfca81b2039809d14ae4691bc.tar.gz
llvm-1262f8a64d21ca0cfca81b2039809d14ae4691bc.tar.bz2
[libc++] Remove the CI job for Apple/System/Noexceptions
When we recently started using DYLD_LIBRARY_PATH to run the test suite on the Apple/System configuration of the library, the -fno-exceptions variant started failing. It started failing because under that configuration, libc++abi.dylib doesn't provide support for exceptions. For example, it doesn't provide some symbols such as ___gxx_personality_v0. Now, the problem is that when the test suite is run with DYLD_LIBRARY_PATH, /usr/lib/libobjc.dylib uses the just-built libc++abi.dylib, which doesn't support exceptions, and we end up with an unresolved reference to ___gxx_personality_v0. Previously, using -Wl,-rpath,path/to/lib, we would be loading both /usr/lib/libc++abi.dylib and <just-built>/lib/libc++abi.dylib. /usr/lib/libobjc.dylib would use the system libc++abi.dylib, which contains support for exceptions, and the tests would be using the just-built one, which doesn't. Disentangling that led me to believe that we shouldn't try to test this configuration where libc++/libc++abi are built as system libraries, but where they don't support exceptions, since that just doesn't make any sense. Doing so is like trying to build libc++/libc++abi and test it as a system library after performing an ABI break -- of course nothing is going to work. For that reason, I am removing this configuration. Note that we could still test the library on macOS without exceptions if we wanted, only we wouldn't be building it as a system library. This patch doesn't add that because we already have a -fno-exceptions CI job on Linux. Differential Revision: https://reviews.llvm.org/D111349
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp')
0 files changed, 0 insertions, 0 deletions