aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
diff options
context:
space:
mode:
authorStephen Tozer <stephen.tozer@sony.com>2024-09-23 15:39:44 +0100
committerGitHub <noreply@github.com>2024-09-23 15:39:44 +0100
commit40d6497a97a61ef5ea38e615cc324104cb34072a (patch)
tree70ef49c3873b867d086c87d0df559a9dbcdce8c8 /lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
parent04d8e364bbf758b2ecbc06b782f1b5dd91bd16e6 (diff)
downloadllvm-40d6497a97a61ef5ea38e615cc324104cb34072a.zip
llvm-40d6497a97a61ef5ea38e615cc324104cb34072a.tar.gz
llvm-40d6497a97a61ef5ea38e615cc324104cb34072a.tar.bz2
[DebugInfo] Transfer strcmp DILocation to generated inline code (#108531)
When AggressiveInstCombine inlines a strcmp call, we currently copy the strcmp's DILocation only to the br instruction that jumps to the inline code. While this is roughly analogous to the original call, it leaves the generated code without any source location, which is precarious for a memory operation. This patch copies the strcmp call's DILocation to all the generated code. An alternative solution would be to generate a new DILocation with a line 0 location and an inlinedAt pointing to the original call location, but this would still give limited attribution to the generated code without traversing the DIE, whereas the submitted solution allows attribution with just the line table; even though it would be technically more accurate, pragmatically I believe that copying the call's location will be more useful for users.
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h')
0 files changed, 0 insertions, 0 deletions