diff options
| author | Andrew Haberlandt <ndrewh@users.noreply.github.com> | 2025-12-09 13:22:54 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-12-09 21:22:54 +0000 |
| commit | 926cbddc185e035a4266f25203e81eec8960f114 (patch) | |
| tree | ebceaaa4eedfdb8e6e590fc164c4db755b90bbe9 /lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp | |
| parent | 8f3c8dabc64517132c9c438ff467e75f39fbf8a6 (diff) | |
| download | llvm-926cbddc185e035a4266f25203e81eec8960f114.zip llvm-926cbddc185e035a4266f25203e81eec8960f114.tar.gz llvm-926cbddc185e035a4266f25203e81eec8960f114.tar.bz2 | |
[sanitizer_common] child_stdin_fd_ should only be set on posix_spawn path (#171508)
#170809 added the child_stdin_fd_ field on SymbolizerProcess to allow
the parent process to hold on to the read in of the child's stdin pipe.
This was to avoid SIGPIPE.
However, the `StartSubprocess` path still closes the stdin fd in the
parent here:
https://github.com/llvm/llvm-project/blob/7f5ed91684c808444ede24eb01ad9af73b5806e5/compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp#L525-L535
This could cause a double-close of this fd (problematic in the case of
fd reuse).
This moves the `child_stdin_fd_` field to only be initialized on the
posix_spawn path. This should ensure #170809 only truly affects Darwin.
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp')
0 files changed, 0 insertions, 0 deletions
