diff options
author | David Spickett <david.spickett@linaro.org> | 2021-11-26 15:16:03 +0000 |
---|---|---|
committer | David Spickett <david.spickett@linaro.org> | 2021-11-26 15:35:02 +0000 |
commit | 0df522969a7a0128052bd79182c8d58e00556e2f (patch) | |
tree | ec8b76aa1b669cb8cc2c2c00b1b49314c9cec2d7 /lldb/source/Plugins/Process/scripted/ScriptedProcess.h | |
parent | 34cc210aa8af2fd33598e5559d0f5b51f9423dd6 (diff) | |
download | llvm-0df522969a7a0128052bd79182c8d58e00556e2f.zip llvm-0df522969a7a0128052bd79182c8d58e00556e2f.tar.gz llvm-0df522969a7a0128052bd79182c8d58e00556e2f.tar.bz2 |
Revert "Reland "[lldb] Remove non address bits when looking up memory regions""
This reverts commit fac3f20de55769d028bd92220e74f22fa57dd4b2.
I found this has broken how we detect the last memory region in
GetMemoryRegions/"memory region" command.
When you're debugging an AArch64 system with pointer authentication,
the ABI plugin will remove the top bit from the end address of the last
user mapped area.
(lldb)
[0x0000fffffffdf000-0x0001000000000000) rw- [stack]
ABI plugin removes anything above the 48th bit (48 bit virtual addresses
by default on AArch64, leaving an address of 0.
(lldb)
[0x0000000000000000-0x0000000000400000) ---
You get back a mapping for 0 and get into an infinite loop.
Diffstat (limited to 'lldb/source/Plugins/Process/scripted/ScriptedProcess.h')
-rw-r--r-- | lldb/source/Plugins/Process/scripted/ScriptedProcess.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lldb/source/Plugins/Process/scripted/ScriptedProcess.h b/lldb/source/Plugins/Process/scripted/ScriptedProcess.h index c8355f3..d56658a 100644 --- a/lldb/source/Plugins/Process/scripted/ScriptedProcess.h +++ b/lldb/source/Plugins/Process/scripted/ScriptedProcess.h @@ -84,6 +84,9 @@ public: ArchSpec GetArchitecture(); + Status GetMemoryRegionInfo(lldb::addr_t load_addr, + MemoryRegionInfo &range_info) override; + Status GetMemoryRegions(lldb_private::MemoryRegionInfos ®ion_list) override; @@ -97,9 +100,6 @@ protected: bool DoUpdateThreadList(ThreadList &old_thread_list, ThreadList &new_thread_list) override; - Status DoGetMemoryRegionInfo(lldb::addr_t load_addr, - MemoryRegionInfo &range_info) override; - private: friend class ScriptedThread; |