diff options
author | David Spickett <david.spickett@linaro.org> | 2021-11-03 13:32:34 +0000 |
---|---|---|
committer | David Spickett <david.spickett@linaro.org> | 2021-11-03 13:56:51 +0000 |
commit | fac3f20de55769d028bd92220e74f22fa57dd4b2 (patch) | |
tree | 75fb6ca38913c0f57839a03a4544f3a4a10d588a /lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h | |
parent | 7a34145f407e4ec652111f5e9483a36f816a6a3a (diff) | |
download | llvm-fac3f20de55769d028bd92220e74f22fa57dd4b2.zip llvm-fac3f20de55769d028bd92220e74f22fa57dd4b2.tar.gz llvm-fac3f20de55769d028bd92220e74f22fa57dd4b2.tar.bz2 |
Reland "[lldb] Remove non address bits when looking up memory regions"
This reverts commit 5fbcf677347e38718461496d9e9e184a7a30c3fb.
ProcessDebugger is used in ProcessWindows and NativeProcessWindows.
I thought I was simplifying things by renaming to DoGetMemoryRegionInfo
in ProcessDebugger but the Native process side expects "GetMemoryRegionInfo".
Follow the pattern that WriteMemory uses. So:
* ProcessWindows::DoGetMemoryRegioninfo calls ProcessDebugger::GetMemoryRegionInfo
* NativeProcessWindows::GetMemoryRegionInfo does the same
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h')
-rw-r--r-- | lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h index 9e05834..8134bc6 100644 --- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h +++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h @@ -144,9 +144,6 @@ public: lldb::addr_t DoAllocateMemory(size_t size, uint32_t permissions, Status &error) override; - Status GetMemoryRegionInfo(lldb::addr_t load_addr, - MemoryRegionInfo ®ion_info) override; - Status DoDeallocateMemory(lldb::addr_t ptr) override; // Process STDIO @@ -424,6 +421,9 @@ protected: Status DoWriteMemoryTags(lldb::addr_t addr, size_t len, int32_t type, const std::vector<uint8_t> &tags) override; + Status DoGetMemoryRegionInfo(lldb::addr_t load_addr, + MemoryRegionInfo ®ion_info) override; + private: // For ProcessGDBRemote only std::string m_partial_profile_data; |