diff options
author | Pavel Labath <labath@google.com> | 2018-02-28 20:42:29 +0000 |
---|---|---|
committer | Pavel Labath <labath@google.com> | 2018-02-28 20:42:29 +0000 |
commit | ec03d7e3babb18f222d9b83a04e747f206f416a5 (patch) | |
tree | 242cc79fe6f09deb8ff99826bfb123cc331a4e65 /lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h | |
parent | fde8b042358ac2b8ac0b7c3a590e9471d3515462 (diff) | |
download | llvm-ec03d7e3babb18f222d9b83a04e747f206f416a5.zip llvm-ec03d7e3babb18f222d9b83a04e747f206f416a5.tar.gz llvm-ec03d7e3babb18f222d9b83a04e747f206f416a5.tar.bz2 |
Revert "[lldb] Use vFlash commands when writing to target's flash memory regions"
This reverts commit r326261 as it introduces inconsistencies in the
handling of load addresses for ObjectFileELF -- some parts of the class
use physical addresses, and some use virtual. This has manifested itself
as us not being able to set the load address of the vdso "module" on
android.
llvm-svn: 326367
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h')
-rw-r--r-- | lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h index 10679e0..42d1c4e 100644 --- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h +++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h @@ -144,8 +144,6 @@ public: size_t DoReadMemory(lldb::addr_t addr, void *buf, size_t size, Status &error) override; - Status WriteObjectFile(std::vector<WriteEntry> entries) override; - size_t DoWriteMemory(lldb::addr_t addr, const void *buf, size_t size, Status &error) override; @@ -304,11 +302,6 @@ protected: int64_t m_breakpoint_pc_offset; lldb::tid_t m_initial_tid; // The initial thread ID, given by stub on attach - bool m_allow_flash_writes; - using FlashRangeVector = lldb_private::RangeVector<lldb::addr_t, size_t>; - using FlashRange = FlashRangeVector::Entry; - FlashRangeVector m_erased_flash_ranges; - //---------------------------------------------------------------------- // Accessors //---------------------------------------------------------------------- @@ -415,12 +408,6 @@ protected: Status UpdateAutomaticSignalFiltering() override; - Status FlashErase(lldb::addr_t addr, size_t size); - - Status FlashDone(); - - bool HasErased(FlashRange range); - private: //------------------------------------------------------------------ // For ProcessGDBRemote only |