diff options
| author | Balazs Benics <benicsbalazs@gmail.com> | 2020-06-29 18:51:24 +0200 |
|---|---|---|
| committer | Balazs Benics <benicsbalazs@gmail.com> | 2020-06-29 18:51:24 +0200 |
| commit | de361df3f6d0f20bf16a8deb9e6219556d028b81 (patch) | |
| tree | 5c04bf2ab3bbf86e331c8906665473d162d22a5c /lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp | |
| parent | 1ef75f53e9e6aeb35a1d46798b3063192ee86f0f (diff) | |
| download | llvm-de361df3f6d0f20bf16a8deb9e6219556d028b81.zip llvm-de361df3f6d0f20bf16a8deb9e6219556d028b81.tar.gz llvm-de361df3f6d0f20bf16a8deb9e6219556d028b81.tar.bz2 | |
[analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug
FalsePositiveRefutationBRVisitor had a bug where the constraints were not
properly collected thus crosschecked with Z3.
This patch demonstratest and fixes that bug.
Bug:
The visitor wanted to collect all the constraints on a BugPath.
Since it is a visitor, it stated the visitation of the BugPath with the node
before the ErrorNode. As a final step, it visited the ErrorNode explicitly,
before it processed the collected constraints.
In principle, the ErrorNode should have visited before every other node.
Since the constraints were collected into a map, mapping each symbol to its
RangeSet, if the map already had a mapping with the symbol, then it was skipped.
This behavior was flawed if:
We already had a constraint on a symbol, but at the end in the ErrorNode we have
a tighter constraint on that. Therefore, this visitor would not utilize that
tighter constraint during the crosscheck validation.
Differential Revision: https://reviews.llvm.org/D78457
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp')
0 files changed, 0 insertions, 0 deletions