diff options
author | jeffreytan81 <jeffreytan@meta.com> | 2024-08-19 15:11:51 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-19 15:11:51 -0700 |
commit | 98f2eb7ddab0cadd1eb6e631458ae8406f7d39a1 (patch) | |
tree | 9271fbae3d50b382153216013b043b586a6deaf9 /lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp | |
parent | 24052538a0bb0144e6997e6b61687e3b8716b6ac (diff) | |
download | llvm-98f2eb7ddab0cadd1eb6e631458ae8406f7d39a1.zip llvm-98f2eb7ddab0cadd1eb6e631458ae8406f7d39a1.tar.gz llvm-98f2eb7ddab0cadd1eb6e631458ae8406f7d39a1.tar.bz2 |
Fix StartDebuggingRequestHandler/ReplModeRequestHandler in lldb-dap (#104824)
`SBCommand::AddCommand()` requires `SBCommandPluginInterface` to be heap
based because it will be stored inside
`std::shared_ptr<lldb::SBCommandPluginInterface>` later for reference
counting. But lldb-dap passes
`StartDebuggingRequestHandler/ReplModeRequestHandler` static function
pointer to it which will cause corruption later during destruction.
This PR fixes this issue by making these two handler heap based.
Co-authored-by: jeffreytan81 <jeffreytan@fb.com>
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp')
0 files changed, 0 insertions, 0 deletions