diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2020-07-29 08:59:57 -0700 |
---|---|---|
committer | Jonas Devlieghere <jonas@devlieghere.com> | 2020-07-29 10:30:20 -0700 |
commit | 4add853647b358d9bb7f162682e806725888848b (patch) | |
tree | b9d1905dd32c969fab474896debcfb190c6afb96 /lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp | |
parent | e7196bdf81251a4df97746fd54b7db749ca99097 (diff) | |
download | llvm-4add853647b358d9bb7f162682e806725888848b.zip llvm-4add853647b358d9bb7f162682e806725888848b.tar.gz llvm-4add853647b358d9bb7f162682e806725888848b.tar.bz2 |
[lldb] Improve platform handling in CreateTargetInternal
Currently, `target create` has no --platform option. However,
TargetList::CreateTargetInternal which is called under the hood, will
return an error when either no platform or multiple matching platforms
are found, saying that a platform should be specified with --platform.
This patch adds the platform option, but that doesn't solve either of
these errors.
- If more than one platform matches, specifying the platform isn't
going to fix that. The current code will only look at the
architecture instead. I've updated the error message to ask the user
to specify an architecture.
- If no architecture is found, specifying a new one via platform isn't
going to change that either because we already try to find one that
matches the given architecture.
Differential revision: https://reviews.llvm.org/D84809
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp')
0 files changed, 0 insertions, 0 deletions