diff options
| author | Alex Langford <alangford@apple.com> | 2023-08-30 15:56:54 -0700 |
|---|---|---|
| committer | Alex Langford <alangford@apple.com> | 2023-08-31 11:27:59 -0700 |
| commit | 14d95b26aee0ac0ac8a70252e8a3c7a986e0e812 (patch) | |
| tree | dc503377a775895434c4f361d4ea3a1a383fe765 /lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp | |
| parent | 3e89aca4463446cf17f75f492abd8724cb2b9f48 (diff) | |
| download | llvm-14d95b26aee0ac0ac8a70252e8a3c7a986e0e812.zip llvm-14d95b26aee0ac0ac8a70252e8a3c7a986e0e812.tar.gz llvm-14d95b26aee0ac0ac8a70252e8a3c7a986e0e812.tar.bz2 | |
[lldb][NFCI] Remove unneeded ConstString conversions
ConstString can be implicitly converted into a llvm::StringRef. This is
very useful in many places, but it also hides places where we are
creating a ConstString only to use it as a StringRef for the entire
lifespan of the ConstString object.
I locally removed the implicit conversion and found some of the places we
were doing this.
Differential Revision: https://reviews.llvm.org/D159237
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp')
| -rw-r--r-- | lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp index 5391187..a4babce 100644 --- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp @@ -129,8 +129,8 @@ enum { class PluginProperties : public Properties { public: - static ConstString GetSettingName() { - return ConstString(ProcessGDBRemote::GetPluginNameStatic()); + static llvm::StringRef GetSettingName() { + return ProcessGDBRemote::GetPluginNameStatic(); } PluginProperties() : Properties() { |