aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
diff options
context:
space:
mode:
authorAlex Langford <alangford@apple.com>2024-03-20 10:46:06 -0700
committerGitHub <noreply@github.com>2024-03-20 10:46:06 -0700
commit10b0e355372fab1f4d585555536525545eef8523 (patch)
tree1cc8bcd41f06efe2a7308ee729889b8c2cd933c3 /lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
parentd42992e71c660d57c89056f6ee4a5be74fa4d1f4 (diff)
downloadllvm-10b0e355372fab1f4d585555536525545eef8523.zip
llvm-10b0e355372fab1f4d585555536525545eef8523.tar.gz
llvm-10b0e355372fab1f4d585555536525545eef8523.tar.bz2
[lldb] Invert relationship between Process and AddressableBits (#85858)
AddressableBits is in the Utility module of LLDB. It currently directly refers to Process, which is from the Target LLDB module. This is a layering violation which concretely means that it is impossible to link anything that uses Utility without it also using Target as well. This is generally not an issue for LLDB (since everything is built together) but it may make it difficult to write unit tests for AddressableBits later on.
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp')
-rw-r--r--lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index 5b9a9d7..871683a 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -900,7 +900,7 @@ void ProcessGDBRemote::DidLaunchOrAttach(ArchSpec &process_arch) {
}
AddressableBits addressable_bits = m_gdb_comm.GetAddressableBits();
- addressable_bits.SetProcessMasks(*this);
+ SetAddressableBitMasks(addressable_bits);
if (process_arch.IsValid()) {
const ArchSpec &target_arch = GetTarget().GetArchitecture();
@@ -2337,7 +2337,7 @@ StateType ProcessGDBRemote::SetThreadStopInfo(StringExtractor &stop_packet) {
}
}
- addressable_bits.SetProcessMasks(*this);
+ SetAddressableBitMasks(addressable_bits);
ThreadSP thread_sp = SetThreadStopInfo(
tid, expedited_register_map, signo, thread_name, reason, description,