diff options
| author | Pavel Labath <pavel@labath.sk> | 2022-09-07 11:25:44 +0200 |
|---|---|---|
| committer | Pavel Labath <pavel@labath.sk> | 2022-09-09 15:10:38 +0200 |
| commit | 89a3691b794cee20187e14a750ecde8b6d3f7e71 (patch) | |
| tree | f2088d71e56b2f3d90e9f30dbc08992a8d6c86be /lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp | |
| parent | 05f56f10ed84dc56bb4fb686c4630aeb4dcbca0b (diff) | |
| download | llvm-89a3691b794cee20187e14a750ecde8b6d3f7e71.zip llvm-89a3691b794cee20187e14a750ecde8b6d3f7e71.tar.gz llvm-89a3691b794cee20187e14a750ecde8b6d3f7e71.tar.bz2 | |
[lldb] Fix ThreadedCommunication races
The Read function could end up blocking if data (or EOF) arrived just as
it was about to start waiting for the events. This was only discovered
now, because we did not have unit tests for this functionality before.
We need to check for data *after* we start listening for incoming
events. There were no changes to the read thread code needed, as we
already use this pattern in SynchronizeWithReadThread, so I just updated
the comments to make it clear that it is used for reading as well.
Differential Revision: https://reviews.llvm.org/D133410
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp')
0 files changed, 0 insertions, 0 deletions