diff options
author | Yixuan Cao <caoyixuan2019@email.szu.edu.cn> | 2025-10-02 13:30:09 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-10-01 22:30:09 -0700 |
commit | bcc85f76700d3f0aebc14bf8b981476c94892ef8 (patch) | |
tree | 5d49bc851d118b10cb458be4ecd023ca6c90e4d1 /lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp | |
parent | d39095b19357b35bda5e874d66343499985e91bf (diff) | |
download | llvm-bcc85f76700d3f0aebc14bf8b981476c94892ef8.zip llvm-bcc85f76700d3f0aebc14bf8b981476c94892ef8.tar.gz llvm-bcc85f76700d3f0aebc14bf8b981476c94892ef8.tar.bz2 |
[compiler-rt][asan][tests] Stabilize wchar tests on Darwin/Android (#161624)
### Summary
Stabilize ASan wchar tests across Darwin and Android. NFC: test-only.
Follow-up to PR #160493 (adds wchar interceptors/tests).
### Motivation
- Darwin: The top frame often resolves to `libclang_rt.asan_*` rather
than a source file, so strict checks that include file/line can fail.
See Chromium issue
[448631142](https://g-issues.chromium.org/issues/448631142).
- Android: The “ERROR:” header can go to logcat instead of stderr, so
FileCheck may not see it; stdout/stderr reordering also makes pre-crash
markers racy. See Android Buildbot
[186/12821](https://lab.llvm.org/buildbot/#/builders/186/builds/12821).
### Changes
- Android:
- Force reports to stderr via `%env_asan_opts=log_to_stderr=1`, avoiding
the “ERROR:” header going to logcat.
- Print the pre-crash “Good so far.” to stderr and `fflush(stderr)` to
avoid stdout/stderr reordering.
- Darwin:
- Relax the stack-frame check to only require the function name
(`wcscpy/wcsncpy/wcscat/wcsncat`) to tolerate `libclang_rt.asan_*`
frames.
- Common:
- Reuse FileCheck var `[[ADDR]]` instead of redefining.
- Make wide string literals `const wchar_t*` to silence
`-Wwritable-strings`.
### Risk
- NFC: test-only; no change to runtime behavior.
### References
- Follow-up to PR #160493.
- Chromium: [448631142](https://g-issues.chromium.org/issues/448631142)
(Darwin failures).
- Android Buildbot:
[186/12821](https://lab.llvm.org/buildbot/#/builders/186/builds/12821).
Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp')
0 files changed, 0 insertions, 0 deletions