diff options
| author | Michał Górny <mgorny@moritz.systems> | 2021-07-28 20:37:52 +0200 |
|---|---|---|
| committer | Michał Górny <mgorny@moritz.systems> | 2021-08-09 12:07:18 +0200 |
| commit | 8bbef4f9afd8b5f6b4435d5bab48b75f048f353c (patch) | |
| tree | 8259604269b311f4195ca7d1527dbe5b67cc776c /lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp | |
| parent | 14735cab655441ba45c4b88ad82f11267e5fe916 (diff) | |
| download | llvm-8bbef4f9afd8b5f6b4435d5bab48b75f048f353c.zip llvm-8bbef4f9afd8b5f6b4435d5bab48b75f048f353c.tar.gz llvm-8bbef4f9afd8b5f6b4435d5bab48b75f048f353c.tar.bz2 | |
[lldb] [gdb-remote] Sync vFile:open mode constants with GDB
Sync the mode constants used to drive vFile:open requests with these
used by GDB and defined for the gdb remote protocol. This makes it
possible to use 'platform file open' after connecting to gdbremote
server (and to some degree to operate on the open file modulo other
incompatibilities).
Differential Revision: https://reviews.llvm.org/D106985
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp')
| -rw-r--r-- | lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp index b81b14f..92ac2c7 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp @@ -501,10 +501,6 @@ GDBRemoteCommunicationServerCommon::Handle_vFile_Open( packet.GetHexByteStringTerminatedBy(path, ','); if (!path.empty()) { if (packet.GetChar() == ',') { - // FIXME - // The flag values for OpenOptions do not match the values used by GDB - // * https://sourceware.org/gdb/onlinedocs/gdb/Open-Flags.html#Open-Flags - // * rdar://problem/46788934 auto flags = File::OpenOptions(packet.GetHexMaxU32(false, 0)); if (packet.GetChar() == ',') { mode_t mode = packet.GetHexMaxU32(false, 0600); |