diff options
author | Simon Tatham <simon.tatham@arm.com> | 2020-02-17 09:11:35 +0000 |
---|---|---|
committer | Simon Tatham <simon.tatham@arm.com> | 2020-02-17 09:30:45 +0000 |
commit | 377b0e2b06f90c4edbd320cf9d833af5979f8f5d (patch) | |
tree | e2d193bd3025f8f48ab49fb7c97386c5e4b9d9d4 /lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp | |
parent | 516ba158b6890bbcca71527ae0719de151b9de5f (diff) | |
download | llvm-377b0e2b06f90c4edbd320cf9d833af5979f8f5d.zip llvm-377b0e2b06f90c4edbd320cf9d833af5979f8f5d.tar.gz llvm-377b0e2b06f90c4edbd320cf9d833af5979f8f5d.tar.bz2 |
[TableGen] Don't elide bitconverts in PatFrag fragments.
Summary:
In the DAG pattern backend, `SimplifyTree` simplifies a pattern by
removing bitconverts between two identical types. But that function is
also run on the fragments list in instances of `PatFrags`, in which
the types haven't been specified yet. So the input and output of the
bitconvert always evaluate to the empty set of types, which makes them
compare equal. So the test always passes, and bitconverts are
unconditionally removed from the PatFrag RHS.
Fixed by spotting the empty type set and using it to inhibit the
optimization.
Reviewers: nhaehnle, hfinkel
Reviewed By: nhaehnle
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D74627
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp')
0 files changed, 0 insertions, 0 deletions