aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
diff options
context:
space:
mode:
authorRaphael Isemann <teemperor@gmail.com>2020-03-24 20:24:48 +0100
committerRaphael Isemann <teemperor@gmail.com>2020-03-24 20:24:50 +0100
commit0ccc4de42eae92d5a7a1b67b29d7921c7f144b8d (patch)
tree91714a4c3de70e10eec933069676b24c99ebfcc4 /lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
parent0a9b91c390b281e90e51d5839557c5a189dd5401 (diff)
downloadllvm-0ccc4de42eae92d5a7a1b67b29d7921c7f144b8d.zip
llvm-0ccc4de42eae92d5a7a1b67b29d7921c7f144b8d.tar.gz
llvm-0ccc4de42eae92d5a7a1b67b29d7921c7f144b8d.tar.bz2
[lldb] Always log if acquiring packet sequence mutex fails
Summary: Currently we only log in debug builds but I don't see why we would do this as this is neither expensive and seems useful. I looked into the git history of this code and it seems originally there was also an assert here and the logging here was the #else branch branch for non-Debug builds. Reviewers: #lldb, labath Reviewed By: labath Subscribers: JDevlieghere Differential Revision: https://reviews.llvm.org/D76698
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp')
-rw-r--r--lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
index edbd408..fdf1397 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
@@ -2797,12 +2797,10 @@ size_t GDBRemoteCommunicationClient::GetCurrentThreadIDs(
thread_ids.push_back(1);
}
} else {
-#if !defined(LLDB_CONFIGURATION_DEBUG)
Log *log(ProcessGDBRemoteLog::GetLogIfAnyCategoryIsSet(GDBR_LOG_PROCESS |
GDBR_LOG_PACKETS));
- LLDB_LOGF(log, "error: failed to get packet sequence mutex, not sending "
- "packet 'qfThreadInfo'");
-#endif
+ LLDB_LOG(log, "error: failed to get packet sequence mutex, not sending "
+ "packet 'qfThreadInfo'");
sequence_mutex_unavailable = true;
}
return thread_ids.size();