diff options
| author | David Spickett <david.spickett@linaro.org> | 2022-01-12 13:30:25 +0000 |
|---|---|---|
| committer | David Spickett <david.spickett@linaro.org> | 2022-01-20 10:47:05 +0000 |
| commit | 585abe3ba506e410b382f8130f72b9368573a781 (patch) | |
| tree | b1c2fb1f846319c90ab61ce38bdecf42281f9a9d /lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp | |
| parent | 782c0dd1a1c235afb09a34e7da4a1267ead14765 (diff) | |
| download | llvm-585abe3ba506e410b382f8130f72b9368573a781.zip llvm-585abe3ba506e410b382f8130f72b9368573a781.tar.gz llvm-585abe3ba506e410b382f8130f72b9368573a781.tar.bz2 | |
[lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits
This better describes the intent of the method. Which for AArch64
is removing the top byte which includes the memory tags.
It does not include pointer signatures, for those we need to use
the ABI plugin. The rename makes this a little more clear.
It's a bit awkward that the memory tag manager is removing the whole
top byte not just the memory tags but it's an improvement for now.
Reviewed By: omjavaid
Differential Revision: https://reviews.llvm.org/D117671
Diffstat (limited to 'lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp')
| -rw-r--r-- | lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp b/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp index 74366d7..b1ac247 100644 --- a/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp +++ b/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp @@ -1365,10 +1365,9 @@ Status NativeProcessLinux::ReadMemoryTags(int32_t type, lldb::addr_t addr, // lldb will align the range it requests but it is not required to by // the protocol so we'll do it again just in case. - // Remove non address bits too. Ptrace calls may work regardless but that + // Remove tag bits too. Ptrace calls may work regardless but that // is not a guarantee. - MemoryTagManager::TagRange range(details->manager->RemoveNonAddressBits(addr), - len); + MemoryTagManager::TagRange range(details->manager->RemoveTagBits(addr), len); range = details->manager->ExpandToGranule(range); // Allocate enough space for all tags to be read @@ -1420,10 +1419,9 @@ Status NativeProcessLinux::WriteMemoryTags(int32_t type, lldb::addr_t addr, // lldb will align the range it requests but it is not required to by // the protocol so we'll do it again just in case. - // Remove non address bits too. Ptrace calls may work regardless but that + // Remove tag bits too. Ptrace calls may work regardless but that // is not a guarantee. - MemoryTagManager::TagRange range(details->manager->RemoveNonAddressBits(addr), - len); + MemoryTagManager::TagRange range(details->manager->RemoveTagBits(addr), len); range = details->manager->ExpandToGranule(range); // Not checking number of tags here, we may repeat them below |