diff options
author | Alex Langford <alangford@apple.com> | 2023-04-18 16:46:12 -0700 |
---|---|---|
committer | Alex Langford <alangford@apple.com> | 2023-04-19 14:16:12 -0700 |
commit | 77e3914be7c99a76a2f728adbb2a169d7cfc5a10 (patch) | |
tree | 0d0e7386219056f65d1c2d30bf9830279c22f222 /lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp | |
parent | 16036f6cc9c7787d940f51a947403e9c1ce24a64 (diff) | |
download | llvm-77e3914be7c99a76a2f728adbb2a169d7cfc5a10.zip llvm-77e3914be7c99a76a2f728adbb2a169d7cfc5a10.tar.gz llvm-77e3914be7c99a76a2f728adbb2a169d7cfc5a10.tar.bz2 |
[lldb][NFCI] Stop creating additional temporary string in Log::VAPrintf
Instead of creating a std::string from the `SmallString`,
let's just use a std::string from the start. I initially tried to make
`SmallString` work but getting it right proved complicated because
`LogHandler::Emit` will take its `StringRef` parameter and touch the raw
`const char *` from it directly, which isn't guaranteed to be
null-terminated with a `SmallString`.
I changed `WriteMessage` to take a `StringRef` instead of a
`const std::string &` for flexibility.
Differential Revision: https://reviews.llvm.org/D148676
Diffstat (limited to 'lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp')
0 files changed, 0 insertions, 0 deletions