aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
diff options
context:
space:
mode:
authorDave Lee <davelee.com@gmail.com>2025-02-13 07:03:00 -0800
committerGitHub <noreply@github.com>2025-02-13 07:03:00 -0800
commit277cb60d9ab4335bcc6aef4366278e1500237d2c (patch)
tree0373aae25610139e0c2490bba536fbd6f67181bc /lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
parentdb2953d80148870ee22b0ffaed883a02174485c4 (diff)
downloadllvm-277cb60d9ab4335bcc6aef4366278e1500237d2c.zip
llvm-277cb60d9ab4335bcc6aef4366278e1500237d2c.tar.gz
llvm-277cb60d9ab4335bcc6aef4366278e1500237d2c.tar.bz2
[lldb] Use LLDB_LOG_ERROR in ObjectFilePECOFF.cpp (NFC) (#126972)
Diffstat (limited to 'lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp')
-rw-r--r--lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp33
1 files changed, 11 insertions, 22 deletions
diff --git a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
index 6d92a20..609968b 100644
--- a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
+++ b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
@@ -861,14 +861,9 @@ ObjectFilePECOFF::AppendFromExportTable(SectionList *sect_list,
for (const auto &entry : m_binary->export_directories()) {
llvm::StringRef sym_name;
if (auto err = entry.getSymbolName(sym_name)) {
- if (log)
- log->Format(
- __FILE__, __func__,
- "ObjectFilePECOFF::AppendFromExportTable - failed to get export "
- "table entry name: {0}",
- llvm::fmt_consume(std::move(err)));
- else
- llvm::consumeError(std::move(err));
+ LLDB_LOG_ERROR(log, std::move(err),
+ "ObjectFilePECOFF::AppendFromExportTable - failed to get "
+ "export table entry name: {0}");
continue;
}
Symbol symbol;
@@ -886,13 +881,10 @@ ObjectFilePECOFF::AppendFromExportTable(SectionList *sect_list,
// it in symtab and make a note using the symbol name.
llvm::StringRef forwarder_name;
if (auto err = entry.getForwardTo(forwarder_name)) {
- if (log)
- log->Format(__FILE__, __func__,
- "ObjectFilePECOFF::AppendFromExportTable - failed to get "
- "forwarder name of forwarder export '{0}': {1}",
- sym_name, llvm::fmt_consume(std::move(err)));
- else
- llvm::consumeError(std::move(err));
+ LLDB_LOG_ERROR(log, std::move(err),
+ "ObjectFilePECOFF::AppendFromExportTable - failed to "
+ "get forwarder name of forwarder export '{1}': {0}",
+ sym_name);
continue;
}
llvm::SmallString<256> new_name = {symbol.GetDisplayName().GetStringRef(),
@@ -904,13 +896,10 @@ ObjectFilePECOFF::AppendFromExportTable(SectionList *sect_list,
uint32_t function_rva;
if (auto err = entry.getExportRVA(function_rva)) {
- if (log)
- log->Format(__FILE__, __func__,
- "ObjectFilePECOFF::AppendFromExportTable - failed to get "
- "address of export entry '{0}': {1}",
- sym_name, llvm::fmt_consume(std::move(err)));
- else
- llvm::consumeError(std::move(err));
+ LLDB_LOG_ERROR(log, std::move(err),
+ "ObjectFilePECOFF::AppendFromExportTable - failed to get "
+ "address of export entry '{1}': {0}",
+ sym_name);
continue;
}
// Skip the symbol if it doesn't look valid.