diff options
| author | Chelsea Cassanova <chelsea_cassanova@apple.com> | 2024-01-16 07:57:18 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-16 07:57:18 -0800 |
| commit | f1ef910b97d6acb80480b79a4144541311369cc9 (patch) | |
| tree | 669f5d39673d5fc164f682af25e9df55388c3694 /lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp | |
| parent | 77610dd10454e87bb387040d2b51100a17ac5755 (diff) | |
| download | llvm-f1ef910b97d6acb80480b79a4144541311369cc9.zip llvm-f1ef910b97d6acb80480b79a4144541311369cc9.tar.gz llvm-f1ef910b97d6acb80480b79a4144541311369cc9.tar.bz2 | |
[lldb][Progress] Separate title and details (#77547)
Per this RFC:
https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717
on improving progress reports, this commit separates the title field and
details field so that the title specifies the category that the progress
report falls under. The details field is added as a part of the
constructor for progress reports and by default is an empty string. In addition, changes the total amount of progress completed into a std::optional. Also
updates the test to check for details being correctly reported from the
event structured data dictionary.
Diffstat (limited to 'lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp')
| -rw-r--r-- | lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp index 43ab87f..0d95a1c 100644 --- a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp +++ b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp @@ -2897,9 +2897,8 @@ void ObjectFileELF::ParseSymtab(Symtab &lldb_symtab) { if (!module_sp) return; - Progress progress( - llvm::formatv("Parsing symbol table for {0}", - m_file.GetFilename().AsCString("<Unknown>"))); + Progress progress("Parsing symbol table", + m_file.GetFilename().AsCString("<Unknown>")); ElapsedTime elapsed(module_sp->GetSymtabParseTime()); // We always want to use the main object file so we (hopefully) only have one |