diff options
author | Michael Buch <michaelbuch12@gmail.com> | 2023-10-30 17:08:25 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-10-30 17:08:25 +0000 |
commit | c3f7ca78101b77fa522f059af520526ff878a5b0 (patch) | |
tree | 3c4c130f172a8fc226ec46daac4911cfef240631 /lldb/source/Commands/CommandObjectThread.cpp | |
parent | 693941132e27d82f068acbb7f27e134989987de6 (diff) | |
download | llvm-c3f7ca78101b77fa522f059af520526ff878a5b0.zip llvm-c3f7ca78101b77fa522f059af520526ff878a5b0.tar.gz llvm-c3f7ca78101b77fa522f059af520526ff878a5b0.tar.bz2 |
[lldb][Test] TestDataFormatterLibcxxChrono.py: skip test on older clang versions (#70544)
These tests were failing on the LLDB public matrix build-bots for older
clang versions:
```
clang-7: warning: argument unused during compilation: '-nostdlib++' [-Wunused-command-line-argument]
error: invalid value 'c++20' in '-std=c++20'
note: use 'c++98' or 'c++03' for 'ISO C++ 1998 with amendments' standard
note: use 'gnu++98' or 'gnu++03' for 'ISO C++ 1998 with amendments and GNU extensions' standard
note: use 'c++11' for 'ISO C++ 2011 with amendments' standard
note: use 'gnu++11' for 'ISO C++ 2011 with amendments and GNU extensions' standard
note: use 'c++14' for 'ISO C++ 2014 with amendments' standard
note: use 'gnu++14' for 'ISO C++ 2014 with amendments and GNU extensions' standard
note: use 'c++17' for 'ISO C++ 2017 with amendments' standard
note: use 'gnu++17' for 'ISO C++ 2017 with amendments and GNU extensions' standard
note: use 'c++2a' for 'Working draft for ISO C++ 2020' standard
note: use 'gnu++2a' for 'Working draft for ISO C++ 2020 with GNU extensions' standard
make: *** [main.o] Error 1
```
The test fails because we try to compile it with `-std=c++20` (which is
required for std::chrono::{days,weeks,months,years}) on clang versions
that don't support the `-std=c++20` flag.
We could change the test to conditionally compile the C++20 parts of the
test based on the `-std=` flag and have two versions of the python
tests, one for the C++11 chrono features and one for the C++20 features.
This patch instead just disables the test on older clang versions
(because it's simpler and we don't really lose important coverage).
Diffstat (limited to 'lldb/source/Commands/CommandObjectThread.cpp')
0 files changed, 0 insertions, 0 deletions