aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Commands/CommandObjectThread.cpp
diff options
context:
space:
mode:
authorCorentin Jabot <corentinjabot@gmail.com>2021-08-20 17:52:28 +0200
committerCorentin Jabot <corentinjabot@gmail.com>2022-06-29 14:57:35 +0200
commit64ab2b1dcc5136a744fcac21d3d2c59e9cce040a (patch)
tree9f02889306fcb41526e4cf66346d2188eb35fd87 /lldb/source/Commands/CommandObjectThread.cpp
parent62e907e9f9e3c1762e6ce1f24f98f4b0ddc82353 (diff)
downloadllvm-64ab2b1dcc5136a744fcac21d3d2c59e9cce040a.zip
llvm-64ab2b1dcc5136a744fcac21d3d2c59e9cce040a.tar.gz
llvm-64ab2b1dcc5136a744fcac21d3d2c59e9cce040a.tar.bz2
Improve handling of static assert messages.
Instead of dumping the string literal (which quotes it and escape every non-ascii symbol), we can use the content of the string when it is a 8 byte string. Wide, UTF-8/UTF-16/32 strings are still completely escaped, until we clarify how these entities should behave (cf https://wg21.link/p2361). `FormatDiagnostic` is modified to escape non printable characters and invalid UTF-8. This ensures that unicode characters, spaces and new lines are properly rendered in static messages. This make clang more consistent with other implementation and fixes this tweet https://twitter.com/jfbastien/status/1298307325443231744 :) Of note, `PaddingChecker` did print out new lines that were later removed by the diagnostic printing code. To be consistent with its tests, the new lines are removed from the diagnostic. Unicode tables updated to both use the Unicode definitions and the Unicode 14.0 data. U+00AD SOFT HYPHEN is still considered a print character to match existing practices in terminals, in addition of being considered a formatting character as per Unicode. Reviewed By: aaron.ballman, #clang-language-wg Differential Revision: https://reviews.llvm.org/D108469
Diffstat (limited to 'lldb/source/Commands/CommandObjectThread.cpp')
0 files changed, 0 insertions, 0 deletions