diff options
| author | Nico Weber <thakis@chromium.org> | 2022-07-23 12:31:31 -0400 |
|---|---|---|
| committer | Nico Weber <thakis@chromium.org> | 2022-07-23 12:35:48 -0400 |
| commit | 1b4b12a34022b13b35755d9c941f7f13753e5e96 (patch) | |
| tree | ae21d18e00f9cf38b86d71e5711178e7e6f089ce /lldb/source/Commands/CommandObjectTarget.cpp | |
| parent | cbfc22392085924c39fbd239884c12a1b5294085 (diff) | |
| download | llvm-1b4b12a34022b13b35755d9c941f7f13753e5e96.zip llvm-1b4b12a34022b13b35755d9c941f7f13753e5e96.tar.gz llvm-1b4b12a34022b13b35755d9c941f7f13753e5e96.tar.bz2 | |
Revert "[NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute." and follow-ups
This reverts commit 9429b67b8e300e638d7828bbcb95585f85c4df4d.
It broke the build on Windows, see comments on https://reviews.llvm.org/D130309
It also reverts these follow-ups:
Revert "Fix buildbot breakage after https://reviews.llvm.org/D130309."
This reverts commit f959d815f4637890ebbacca379f1c38ab47e4e14.
Revert "Fix buildbot breakage after https://reviews.llvm.org/D130309."
This reverts commit 0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24.
Revert "Cache the value for absolute path in FileSpec."
This reverts commit dabe877248b85b34878e75d5510339325ee087d0.
Diffstat (limited to 'lldb/source/Commands/CommandObjectTarget.cpp')
| -rw-r--r-- | lldb/source/Commands/CommandObjectTarget.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp index f72d4c7..3dcb355 100644 --- a/lldb/source/Commands/CommandObjectTarget.cpp +++ b/lldb/source/Commands/CommandObjectTarget.cpp @@ -406,7 +406,7 @@ protected: if (core_file) { FileSpec core_file_dir; - core_file_dir.SetDirectory(core_file.GetDirectory()); + core_file_dir.GetDirectory() = core_file.GetDirectory(); target_sp->AppendExecutableSearchPaths(core_file_dir); ProcessSP process_sp(target_sp->CreateProcess( @@ -4072,7 +4072,7 @@ protected: if (!module_spec.GetUUID().IsValid()) { if (!module_spec.GetFileSpec() && !module_spec.GetPlatformFileSpec()) - module_spec.GetFileSpec().SetFilename(symbol_fspec.GetFilename()); + module_spec.GetFileSpec().GetFilename() = symbol_fspec.GetFilename(); } // Now module_spec represents a symbol file for a module that might exist @@ -4136,7 +4136,7 @@ protected: break; // Replace basename with one fewer extension - module_spec.GetFileSpec().SetFilename(filename_no_extension); + module_spec.GetFileSpec().GetFilename() = filename_no_extension; target->GetImages().FindModules(module_spec, matching_modules); } |