diff options
author | Jakub Kuderski <jakub@nod-labs.com> | 2023-11-27 11:19:20 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-11-27 11:19:20 -0500 |
commit | e0aac8c88d0d30e8da0f8a240ad1e6b4d88782e0 (patch) | |
tree | 99400ed288c55191155f46639ce0d51fdf9dd57c /lldb/source/Commands/CommandObjectProcess.cpp | |
parent | 6b9c186b2d4c8bd315034a9655a28d32bcf745ab (diff) | |
download | llvm-e0aac8c88d0d30e8da0f8a240ad1e6b4d88782e0.zip llvm-e0aac8c88d0d30e8da0f8a240ad1e6b4d88782e0.tar.gz llvm-e0aac8c88d0d30e8da0f8a240ad1e6b4d88782e0.tar.bz2 |
[mlir][gpu] Align reduction operations with vector combining kinds (#73423)
The motivation for this change is explained in
https://github.com/llvm/llvm-project/issues/72354.
Before this change, we could not tell between signed/unsigned
minimum/maximum and NaN treatment for floating point values.
The mapping of old reduction operations to the new ones is as follows:
* `min` --> `minsi` for ints, `minf` for floats
* `max` --> `maxsi` for ints, `maxf` for floats
New reduction kinds not represented in the old enum: `minui`, `maxui`,
`minimumf`, `maximumf`.
As a next step, I would like to have a common definition of combining
kinds used by the `vector` and `gpu` dialects. Separately, the GPU to
SPIR-V lowering does not yet properly handle zero and NaN values -- the
behavior of floating point min/max group reductions is not specified by
the SPIR-V spec, see https://github.com/llvm/llvm-project/issues/73459.
Issue: https://github.com/llvm/llvm-project/issues/72354
Diffstat (limited to 'lldb/source/Commands/CommandObjectProcess.cpp')
0 files changed, 0 insertions, 0 deletions