Revert "[lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (#129092)"

And a follow up warning fix.

This reverts commit 6aa963f780d63d4c8fa80de97dd79c932bc35f4e
and 2bff80f25d51e24d3c552e033a2863dd36ef648b.

This is failing on Windows on Arm: https://lab.llvm.org/buildbot/#/builders/141/builds/8375

Seems to produce the line the test wants but not in the right place.
Reverting while I investigate.

1 files changed, 0 insertions, 13 deletions

diff --git a/lldb/source/Commands/CommandObjectProcess.cpp b/lldb/source/Commands/CommandObjectProcess.cpp
index d0f5eaf..ed80c85 100644
--- a/lldb/source/Commands/CommandObjectProcess.cpp
+++ b/lldb/source/Commands/CommandObjectProcess.cpp
@@ -1388,9 +1388,6 @@ public:
       case 'v':
         m_verbose = true;
         break;
-      case 'd':
-        m_dump = true;
-        break;
       default:
         llvm_unreachable("Unimplemented option");
       }
@@ -1400,7 +1397,6 @@ public:
 
     void OptionParsingStarting(ExecutionContext *execution_context) override {
       m_verbose = false;
-      m_dump = false;
     }
 
     llvm::ArrayRef<OptionDefinition> GetDefinitions() override {
@@ -1409,7 +1405,6 @@ public:
 
     // Instance variables to hold the values for command options.
     bool m_verbose = false;
-    bool m_dump = false;
   };
 
 protected:
@@ -1464,14 +1459,6 @@ protected:
         crash_info_sp->GetDescription(strm);
       }
     }
-
-    if (m_options.m_dump) {
-      StateType state = process->GetState();
-      if (state == eStateStopped) {
-        ProcessModID process_mod_id = process->GetModID();
-        process_mod_id.Dump(result.GetOutputStream());
-      }
-    }
   }
 
 private: