diff options
| author | Georgii Rymar <grimar@accesssoftek.com> | 2020-08-20 18:40:52 +0300 |
|---|---|---|
| committer | Georgii Rymar <grimar@accesssoftek.com> | 2020-08-21 11:35:28 +0300 |
| commit | 80e9dd08784fc4f28bb04a8e9c0639d433a94d08 (patch) | |
| tree | 2decd55b530067b21d690c5b34fa89a2057d2691 /lldb/source/Commands/CommandObjectProcess.cpp | |
| parent | a0e92ffd0d663a6f1c39239847d15c0d65d2c3d6 (diff) | |
| download | llvm-80e9dd08784fc4f28bb04a8e9c0639d433a94d08.zip llvm-80e9dd08784fc4f28bb04a8e9c0639d433a94d08.tar.gz llvm-80e9dd08784fc4f28bb04a8e9c0639d433a94d08.tar.bz2 | |
[llvm-readobj] - Change how we create DynRegionInfo objects. NFCI.
Currently we have `checkDRI` and two `createDRIFrom` methods which
are used to create `DynRegionInfo` objects.
And we have an issue: constructions like:
`ObjF->getELFFile()->base() + P->p_offset`
that are used in `createDRIFrom` functions might overflow.
I had to revert `D85519` which triggered such UBSan failure.
This NFC, simplifies and generalizes how we create `DynRegionInfo` objects.
It will allow us to introduce more/better validation checks in a single place.
It also will allow to change `createDRI` to return `Expected<>` so
that we will be able to stop using the `reportError`, which
is used inside currently, and have a warning instead.
Differential revision: https://reviews.llvm.org/D86297
Diffstat (limited to 'lldb/source/Commands/CommandObjectProcess.cpp')
0 files changed, 0 insertions, 0 deletions