diff options
| author | Douglas Gregor <dgregor@apple.com> | 2010-12-03 17:11:42 +0000 |
|---|---|---|
| committer | Douglas Gregor <dgregor@apple.com> | 2010-12-03 17:11:42 +0000 |
| commit | 17fed4c7542a358bebd6587471bb8f99ae2a71bc (patch) | |
| tree | c3285cb69942c8d274a9c27d461f6e9136497f53 /lldb/source/Commands/CommandObjectProcess.cpp | |
| parent | e674f09c1e89d24ff0651206b4c644a46aa7eadd (diff) | |
| download | llvm-17fed4c7542a358bebd6587471bb8f99ae2a71bc.zip llvm-17fed4c7542a358bebd6587471bb8f99ae2a71bc.tar.gz llvm-17fed4c7542a358bebd6587471bb8f99ae2a71bc.tar.bz2 | |
Implement caching for the linkage and visibility calculations of
declarations.
The motivation for this patch is that linkage/visibility computations
are linear in the number of redeclarations of an entity, and we've run
into a case where a single translation unit has > 6500 redeclarations
of the same (unused!) external variable. Since each redeclaration
involves a linkage check, the resulting quadratic behavior makes Clang
slow to a crawl. With this change, a simple test with 512
redeclarations of a variable syntax-checks ~20x faster than
before.
That said, I hate this change, and will probably end up reverting it
in a few hours. Reasons to hate it:
- It makes NamedDecl larger, since we don't have enough free bits in
Decl to squeeze in the extra information about caching.
- There are way too many places where we need to invalidate this
cache, because the visibility of a declaration can change due to
redeclarations (!). Despite self-hosting and passing the testsuite,
I have no confidence that I've found all of places where this cache
needs to be invalidated.
llvm-svn: 120808
Diffstat (limited to 'lldb/source/Commands/CommandObjectProcess.cpp')
0 files changed, 0 insertions, 0 deletions
