diff options
author | Raphael Isemann <teemperor@gmail.com> | 2019-09-13 11:26:48 +0000 |
---|---|---|
committer | Raphael Isemann <teemperor@gmail.com> | 2019-09-13 11:26:48 +0000 |
commit | 0d9a201e2624998922f825ebbe01aae0cce4bbd5 (patch) | |
tree | 3d844315931e3026c40a44de0d2117368e82360d /lldb/source/Commands/CommandObjectProcess.cpp | |
parent | 930ebc15a6398710e84eea16b735721fe4a2c2fd (diff) | |
download | llvm-0d9a201e2624998922f825ebbe01aae0cce4bbd5.zip llvm-0d9a201e2624998922f825ebbe01aae0cce4bbd5.tar.gz llvm-0d9a201e2624998922f825ebbe01aae0cce4bbd5.tar.bz2 |
[lldb][NFC] Remove ArgEntry::ref member
The StringRef should always be identical to the C string, so we
might as well just create the StringRef from the C-string. This
might be slightly slower until we implement the storage of ArgEntry
with a string instead of a std::unique_ptr<char[]>. Until then we
have to do the additional strlen on the C string to construct the
StringRef.
llvm-svn: 371842
Diffstat (limited to 'lldb/source/Commands/CommandObjectProcess.cpp')
-rw-r--r-- | lldb/source/Commands/CommandObjectProcess.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lldb/source/Commands/CommandObjectProcess.cpp b/lldb/source/Commands/CommandObjectProcess.cpp index eb559cd..b494740 100644 --- a/lldb/source/Commands/CommandObjectProcess.cpp +++ b/lldb/source/Commands/CommandObjectProcess.cpp @@ -923,7 +923,7 @@ protected: for (auto &entry : command.entries()) { Status error; PlatformSP platform = process->GetTarget().GetPlatform(); - llvm::StringRef image_path = entry.ref; + llvm::StringRef image_path = entry.ref(); uint32_t image_token = LLDB_INVALID_IMAGE_TOKEN; if (!m_options.do_install) { @@ -985,9 +985,9 @@ protected: for (auto &entry : command.entries()) { uint32_t image_token; - if (entry.ref.getAsInteger(0, image_token)) { + if (entry.ref().getAsInteger(0, image_token)) { result.AppendErrorWithFormat("invalid image index argument '%s'", - entry.ref.str().c_str()); + entry.ref().str().c_str()); result.SetStatus(eReturnStatusFailed); break; } else { |