aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Commands/CommandObjectPlatform.cpp
diff options
context:
space:
mode:
authorJuan Manuel MARTINEZ CAAMAÑO <juamarti@amd.com>2023-06-29 09:31:34 +0200
committerJuan Manuel MARTINEZ CAAMAÑO <juamarti@amd.com>2023-06-29 09:49:16 +0200
commitdd1df099ae37c2a68a20c96615b7ed7474eacec4 (patch)
treebb6e2512e038cb79fdec3c251b1d75bca948f587 /lldb/source/Commands/CommandObjectPlatform.cpp
parentcc8a346e3fa362c2b1319cca9883182fbf36b6db (diff)
downloadllvm-dd1df099ae37c2a68a20c96615b7ed7474eacec4.zip
llvm-dd1df099ae37c2a68a20c96615b7ed7474eacec4.tar.gz
llvm-dd1df099ae37c2a68a20c96615b7ed7474eacec4.tar.bz2
[InlineCost][TargetTransformInfo][AMDGPU] Consider cost of alloca instructions in the caller (2/2)
Before this patch, the compiler gave a bump to the inline-threshold when the total size of the allocas passed as arguments to the callee was below 256 bytes. This heuristic ignores that some of these allocas could have be removed by SROA if inlining was applied. Ideally, this bonus would be attributed to the threshold once the size of all the allocas that could not be handled by SROA is known: at the end of the InlineCost analysis. However, we may never reach this point if the inline-cost analysis exits early when the inline cost goes over the threshold mid-analysis. This patch proposes: * Attribute the bonus in the inline-threshold when allocas are passed as arguments (regardless of their total size). * Assigns a cost to each alloca proportional to its size, such that the cost of all the allocas cancels the bonus. Potential problems: * This patch assumes that removing alloca instructions with SROA is always profitable. This may not be the case if the total size of the allocas is still too big to be promoted to registers/LDS. * Redundant calls to getTotalAllocaSize * Awkwardly, the threshold attributed contributes to the single-bb and vector bonus. Reviewed By: scchan Differential Revision: https://reviews.llvm.org/D149741
Diffstat (limited to 'lldb/source/Commands/CommandObjectPlatform.cpp')
0 files changed, 0 insertions, 0 deletions