diff options
| author | Felipe de Azevedo Piovezan <fpiovezan@apple.com> | 2023-06-27 16:10:05 -0400 |
|---|---|---|
| committer | Felipe de Azevedo Piovezan <fpiovezan@apple.com> | 2023-06-27 18:09:40 -0400 |
| commit | ab674234c440ed27302f58eeccc612c83b32c43f (patch) | |
| tree | a83e51969d42c19fcb418c21b26e40a5247d809f /lldb/source/Commands/CommandObjectPlatform.cpp | |
| parent | f3ebd88064d7f1c36a8272b3e5f7d53501c3f53b (diff) | |
| download | llvm-ab674234c440ed27302f58eeccc612c83b32c43f.zip llvm-ab674234c440ed27302f58eeccc612c83b32c43f.tar.gz llvm-ab674234c440ed27302f58eeccc612c83b32c43f.tar.bz2 | |
[lldb][NFC] Prevent slicing when converting DataExtractors
LLDB's implementation of DWARFDataExtractor has a method that returns a
llvm::DWARFDataExtractor. In some cases, like DebugNamesDWARFIndex::Create, we
were passing an LLVM::DWARFDataExtractor to a function that expects a
LLVM:DataExtractor by value. This is causing slicing of the derived class.
While slicing is not inherently bad, it can be dangerous if the constructor of
the derived class mutates the base class in a way that leaves it in an invalid
state after slicing.
Differential Revision: https://reviews.llvm.org/D153913
Diffstat (limited to 'lldb/source/Commands/CommandObjectPlatform.cpp')
0 files changed, 0 insertions, 0 deletions