diff options
| author | David Spickett <david.spickett@linaro.org> | 2022-09-16 12:48:58 +0000 |
|---|---|---|
| committer | David Spickett <david.spickett@linaro.org> | 2022-09-23 12:32:12 +0000 |
| commit | ee582001bf19be8611257df7c5fc5a5e7e7da586 (patch) | |
| tree | 7e8ba58c988d5d0c6b6560b35ba74e30d4fc4e51 /lldb/source/Commands/CommandObjectMemory.cpp | |
| parent | 181f200a1c76c4ddf50a9d5bb091bf32781bfbf7 (diff) | |
| download | llvm-ee582001bf19be8611257df7c5fc5a5e7e7da586.zip llvm-ee582001bf19be8611257df7c5fc5a5e7e7da586.tar.gz llvm-ee582001bf19be8611257df7c5fc5a5e7e7da586.tar.bz2 | |
[LLDB] Properly return errors from "memory region --all"
When I wrote the initial version I forgot that a region being
unmapped is not an error. There are real errors that we don't
want to hide, such as the remote not supporting the
qMemoryRegionInfo packet (gdbserver does not).
Reviewed By: labath
Differential Revision: https://reviews.llvm.org/D134029
Diffstat (limited to 'lldb/source/Commands/CommandObjectMemory.cpp')
| -rw-r--r-- | lldb/source/Commands/CommandObjectMemory.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/lldb/source/Commands/CommandObjectMemory.cpp b/lldb/source/Commands/CommandObjectMemory.cpp index 22483e7..33c40a9 100644 --- a/lldb/source/Commands/CommandObjectMemory.cpp +++ b/lldb/source/Commands/CommandObjectMemory.cpp @@ -1830,9 +1830,6 @@ protected: addr = region_info.GetRange().GetRangeEnd(); } } - - // Even if we read nothing, don't error for --all - error.Clear(); } else { lldb_private::MemoryRegionInfo region_info; error = process_sp->GetMemoryRegionInfo(load_addr, region_info); |