diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2025-09-04 16:37:41 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-09-04 16:37:41 -0700 |
commit | 820f4402745dda82fca482f2b83925e2953e6ad9 (patch) | |
tree | e4e8cc10b5ed14a8f91e0e0a85092e2600271a33 /lldb/source/Commands/CommandObjectFrame.cpp | |
parent | fb5626fdd52905a0f4ade44221f83f0e469b9a8c (diff) | |
download | llvm-820f4402745dda82fca482f2b83925e2953e6ad9.zip llvm-820f4402745dda82fca482f2b83925e2953e6ad9.tar.gz llvm-820f4402745dda82fca482f2b83925e2953e6ad9.tar.bz2 |
[lldb] Correct style of error messages (#156774)
The LLVM Style Guide says the following about error and warning messages
[1]:
> [T]o match error message styles commonly produced by other tools,
> start the first sentence with a lowercase letter, and finish the last
> sentence without a period, if it would end in one otherwise.
I often provide this feedback during code review, but we still have a
bunch of places where we have inconsistent error message, which bothers
me as a user. This PR identifies a handful of those places and updates
the messages to be consistent.
[1] https://llvm.org/docs/CodingStandards.html#error-and-warning-messages
Diffstat (limited to 'lldb/source/Commands/CommandObjectFrame.cpp')
-rw-r--r-- | lldb/source/Commands/CommandObjectFrame.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lldb/source/Commands/CommandObjectFrame.cpp b/lldb/source/Commands/CommandObjectFrame.cpp index 7e58a95..88a02dc 100644 --- a/lldb/source/Commands/CommandObjectFrame.cpp +++ b/lldb/source/Commands/CommandObjectFrame.cpp @@ -140,7 +140,7 @@ protected: } else { StopInfoSP stop_info_sp = thread->GetStopInfo(); if (!stop_info_sp) { - result.AppendError("No arguments provided, and no stop info."); + result.AppendError("no arguments provided, and no stop info"); return; } @@ -148,7 +148,7 @@ protected: } if (!valobj_sp) { - result.AppendError("No diagnosis available."); + result.AppendError("no diagnosis available"); return; } @@ -310,7 +310,7 @@ protected: if (frame_idx == 0) { // If you are already at the bottom of the stack, then just warn // and don't reset the frame. - result.AppendError("Already at the bottom of the stack."); + result.AppendError("already at the bottom of the stack"); return; } else frame_idx = 0; @@ -335,7 +335,7 @@ protected: if (frame_idx == num_frames - 1) { // If we are already at the top of the stack, just warn and don't // reset the frame. - result.AppendError("Already at the top of the stack."); + result.AppendError("already at the top of the stack"); return; } else frame_idx = num_frames - 1; |