Make llvm::StringRef to std::string conversions explicit.

This is how it should've been and brings it more in line with
std::string_view. There should be no functional change here.

This is mostly mechanical from a custom clang-tidy check, with a lot of
manual fixups. It uncovers a lot of minor inefficiencies.

This doesn't actually modify StringRef yet, I'll do that in a follow-up.

1 files changed, 3 insertions, 3 deletions

diff --git a/lldb/source/Commands/CommandObjectDisassemble.cpp b/lldb/source/Commands/CommandObjectDisassemble.cpp
index 9e80640..d513133 100644
--- a/lldb/source/Commands/CommandObjectDisassemble.cpp
+++ b/lldb/source/Commands/CommandObjectDisassemble.cpp
@@ -83,7 +83,7 @@ Status CommandObjectDisassemble::CommandOptions::SetOptionValue(
   } break;
 
   case 'n':
-    func_name.assign(option_arg);
+    func_name.assign(std::string(option_arg));
     some_location_specified = true;
     break;
 
@@ -101,7 +101,7 @@ Status CommandObjectDisassemble::CommandOptions::SetOptionValue(
     break;
 
   case 'P':
-    plugin_name.assign(option_arg);
+    plugin_name.assign(std::string(option_arg));
     break;
 
   case 'F': {
@@ -111,7 +111,7 @@ Status CommandObjectDisassemble::CommandOptions::SetOptionValue(
                           llvm::Triple::x86 ||
                       target_sp->GetArchitecture().GetTriple().getArch() ==
                           llvm::Triple::x86_64)) {
-      flavor_string.assign(option_arg);
+      flavor_string.assign(std::string(option_arg));
     } else
       error.SetErrorStringWithFormat("Disassembler flavors are currently only "
                                      "supported for x86 and x86_64 targets.");