diff options
author | Alex Cameron <ascottcameron@gmail.com> | 2020-03-09 11:58:12 +0000 |
---|---|---|
committer | Nathan James <n.james93@hotmail.co.uk> | 2020-03-09 12:05:57 +0000 |
commit | 62af02e76fe808134b06b75c8108a98c079ac8bc (patch) | |
tree | 80bfdcc224fb5abafdbbc8612236094afaddbe50 /lldb/source/Commands/CommandObjectDisassemble.cpp | |
parent | 6d2032e259c70a77679e47c52b6b2b35413a4f25 (diff) | |
download | llvm-62af02e76fe808134b06b75c8108a98c079ac8bc.zip llvm-62af02e76fe808134b06b75c8108a98c079ac8bc.tar.gz llvm-62af02e76fe808134b06b75c8108a98c079ac8bc.tar.bz2 |
[XRay] Sanitize DOT labels in graph output
Summary:
Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=39701
This patch is to convert certain characters to their XML escape sequences when generating labels for a DOT graph.
I had trouble reproducing the exact issue described on the tracker. I ran `llvm-xray graph` on a log from a test program that included function templates but wasn't able to get the `dot` tool to complain about the `<` and `>` characters. The documentation also suggests that the escape sequences should only be necessary when using HTML string labels which XRay doesn't use (`label=<...>` as opposed to `label="..."`). Perhaps newer versions of Graphviz silently handle this in the case of quoted-string labels.
In any case, the generated labels still look correct after this patch and should also fix the reporter's issue.
I was a bit unsure how to add a test for this since the existing tests seem to only care about `func-id` rather than giving an actual name. If you could give me a hint on the best way to go about this, that'd be much appreciated!
Reviewers: dberris
Reviewed By: dberris
Subscribers: lebedev.ri, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69461
Diffstat (limited to 'lldb/source/Commands/CommandObjectDisassemble.cpp')
0 files changed, 0 insertions, 0 deletions