Make llvm::StringRef to std::string conversions explicit.

This is how it should've been and brings it more in line with
std::string_view. There should be no functional change here.

This is mostly mechanical from a custom clang-tidy check, with a lot of
manual fixups. It uncovers a lot of minor inefficiencies.

This doesn't actually modify StringRef yet, I'll do that in a follow-up.

1 files changed, 2 insertions, 2 deletions

diff --git a/lldb/source/Commands/CommandCompletions.cpp b/lldb/source/Commands/CommandCompletions.cpp
index ea494af..e5f2911 100644
--- a/lldb/source/Commands/CommandCompletions.cpp
+++ b/lldb/source/Commands/CommandCompletions.cpp
@@ -295,7 +295,7 @@ void CommandCompletions::SettingsNames(CommandInterpreter &interpreter,
     if (properties_sp) {
       StreamString strm;
       properties_sp->DumpValue(nullptr, strm, OptionValue::eDumpOptionName);
-      const std::string &str = strm.GetString();
+      const std::string &str = std::string(strm.GetString());
       g_property_names.SplitIntoLines(str.c_str(), str.size());
     }
   }
@@ -414,7 +414,7 @@ CommandCompletions::SymbolCompleter::SymbolCompleter(
   std::string regex_str;
   if (!m_request.GetCursorArgumentPrefix().empty()) {
     regex_str.append("^");
-    regex_str.append(m_request.GetCursorArgumentPrefix());
+    regex_str.append(std::string(m_request.GetCursorArgumentPrefix()));
   } else {
     // Match anything since the completion string is empty
     regex_str.append(".");