aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/API/SBDebugger.cpp
diff options
context:
space:
mode:
authorRaphael Isemann <teemperor@gmail.com>2020-08-17 11:03:36 +0200
committerRaphael Isemann <teemperor@gmail.com>2020-08-17 11:30:56 +0200
commit24c74f5e8c2cf263dd84292ca5d33ee0890b48dd (patch)
treea4356161a9999f61be0caf23cc97ecac1dfaab7c /lldb/source/API/SBDebugger.cpp
parent67cdb899c6b3ec231f35ca17a00023758ef127ba (diff)
downloadllvm-24c74f5e8c2cf263dd84292ca5d33ee0890b48dd.zip
llvm-24c74f5e8c2cf263dd84292ca5d33ee0890b48dd.tar.gz
llvm-24c74f5e8c2cf263dd84292ca5d33ee0890b48dd.tar.bz2
[lldb] Don't delete orphaned shared modules in SBDebugger::DeleteTarget
In D83876 the consensus seems that LLDB should never deleted orphaned modules implicitly. However, SBDebugger::DeleteTarget is currently doing exactly that. This code was added in 753406221b55b95141c8c1239660dc4db4e35ea5 but I don't see any explanation in the commit, so I think we should delete it. Reviewed By: clayborg Differential Revision: https://reviews.llvm.org/D83933
Diffstat (limited to 'lldb/source/API/SBDebugger.cpp')
-rw-r--r--lldb/source/API/SBDebugger.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/lldb/source/API/SBDebugger.cpp b/lldb/source/API/SBDebugger.cpp
index 5f62987..b39481c 100644
--- a/lldb/source/API/SBDebugger.cpp
+++ b/lldb/source/API/SBDebugger.cpp
@@ -879,8 +879,6 @@ bool SBDebugger::DeleteTarget(lldb::SBTarget &target) {
result = m_opaque_sp->GetTargetList().DeleteTarget(target_sp);
target_sp->Destroy();
target.Clear();
- const bool mandatory = true;
- ModuleList::RemoveOrphanSharedModules(mandatory);
}
}