aboutsummaryrefslogtreecommitdiff
path: root/lldb/packages/Python/lldbsuite
diff options
context:
space:
mode:
authorAndrew Rogers <andrurogerz@gmail.com>2024-07-23 09:23:51 -0700
committerGitHub <noreply@github.com>2024-07-23 09:23:51 -0700
commitca102b2114fa8a00096d71ff9fc3b1b218f0f01a (patch)
tree4af6a6a03967c440d8bee23f0e2393097f870232 /lldb/packages/Python/lldbsuite
parent1e58c9de75d39ba5fa3d8373c6a631685f926014 (diff)
downloadllvm-ca102b2114fa8a00096d71ff9fc3b1b218f0f01a.zip
llvm-ca102b2114fa8a00096d71ff9fc3b1b218f0f01a.tar.gz
llvm-ca102b2114fa8a00096d71ff9fc3b1b218f0f01a.tar.bz2
lldb: android: fix missing Python import of urlparse in lldb test utilities (#99934)
## Issue Attempting to run the lldb API tests against a remote-android target fails with the error `NameError: name 'urlparse' is not defined`. ## Root Cause It looks the Python import of `urlparse` was removed by mistake in 22ea97d7bfd65abf68a68b13bf96ad69be23df54. This import is only used when running the lldb API tests against a remote-android target so it went unnoticed. ## Fix This change simply puts back the missing import. It is a one line change. fixes #99931 ## Validation Tested on Fedora 39 with an attached Android device: `cd llvm-project` `cmake -S llvm -B build -G Ninja -DLLVM_ENABLE_PROJECTS='clang;lldb' -DCMAKE_BUILD_TYPE=Release -DLLDB_ENABLE_PYTHON=On` `ninja -C build` `./build/bin/lldb-dotest --arch aarch64 --out-of-tree-debugserver --platform-name=remote-android --platform-working-dir=/data/local/tmp/ds2 --platform-url=connect://localhost:5432 --compiler ~/Android/Sdk/ndk/21.4.7075529/toolchains/llvm/prebuilt/linux-x86_64/bin/clang`
Diffstat (limited to 'lldb/packages/Python/lldbsuite')
-rw-r--r--lldb/packages/Python/lldbsuite/test/lldbplatformutil.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py b/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
index b7e6f24..e3c6fd1 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
@@ -9,6 +9,7 @@ import subprocess
import sys
import os
from packaging import version
+from urllib.parse import urlparse
# LLDB modules
import lldb