diff options
author | Pavel Labath <pavel@labath.sk> | 2022-02-25 14:47:27 +0100 |
---|---|---|
committer | Pavel Labath <pavel@labath.sk> | 2022-04-13 14:41:13 +0200 |
commit | af921006d3792fa28d1070f015dcfd145e082ed2 (patch) | |
tree | cef66cd21a920de4d0e7596f9a53da2756740f91 /lldb/packages/Python/lldbsuite | |
parent | ba4537b22796a561dbcd7cd4e666bb5039510b21 (diff) | |
download | llvm-af921006d3792fa28d1070f015dcfd145e082ed2.zip llvm-af921006d3792fa28d1070f015dcfd145e082ed2.tar.gz llvm-af921006d3792fa28d1070f015dcfd145e082ed2.tar.bz2 |
[lldb] Remove the global platform list
This patch moves the platform creation and selection logic into the
per-debugger platform lists. I've tried to keep functional changes to a
minimum -- the main (only) observable difference in this change is that
APIs, which select a platform by name (e.g.,
Debugger::SetCurrentPlatform) will not automatically pick up a platform
associated with another debugger (or no debugger at all).
I've also added several tests for this functionality -- one of the
pleasant consequences of the debugger isolation is that it is now
possible to test the platform selection and creation logic.
This is a product of the discussion at
<https://discourse.llvm.org/t/multiple-platforms-with-the-same-name/59594>.
Differential Revision: https://reviews.llvm.org/D120810
Diffstat (limited to 'lldb/packages/Python/lldbsuite')
-rw-r--r-- | lldb/packages/Python/lldbsuite/test/dotest.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py index 489e6ce..a9ca741 100644 --- a/lldb/packages/Python/lldbsuite/test/dotest.py +++ b/lldb/packages/Python/lldbsuite/test/dotest.py @@ -902,6 +902,7 @@ def run_suite(): (configuration.lldb_platform_name)) lldb.remote_platform = lldb.SBPlatform( configuration.lldb_platform_name) + lldb.selected_platform = lldb.remote_platform if not lldb.remote_platform.IsValid(): print( "error: unable to create the LLDB platform named '%s'." % @@ -918,7 +919,6 @@ def run_suite(): err = lldb.remote_platform.ConnectRemote(platform_connect_options) if err.Success(): print("Connected.") - lldb.selected_platform = lldb.remote_platform else: print("error: failed to connect to remote platform using URL '%s': %s" % ( configuration.lldb_platform_url, err)) |