diff options
author | Pavel Labath <labath@google.com> | 2018-04-24 08:29:20 +0000 |
---|---|---|
committer | Pavel Labath <labath@google.com> | 2018-04-24 08:29:20 +0000 |
commit | 60b7132a7c41b3112c5afb01139564a4f6184002 (patch) | |
tree | 8935778250ceb52ea51cf266b06146e216acc257 /lldb/packages/Python/lldbsuite/test | |
parent | bb156b52cf13de77985c5cd480db3d7089ee95be (diff) | |
download | llvm-60b7132a7c41b3112c5afb01139564a4f6184002.zip llvm-60b7132a7c41b3112c5afb01139564a4f6184002.tar.gz llvm-60b7132a7c41b3112c5afb01139564a4f6184002.tar.bz2 |
[Support/Path] Add more tests and improve failure messages of existing ones
Summary:
I am preparing a patch to the path function. While working on it, I
noticed that some of the areas are lacking test coverage (e.g. filename
and parent_path functions), so I add more tests to guard against
regressions there.
I have also found the failure messages hard to understand, so I rewrote
some existing test to give more actionable messages when they fail:
- for tests which run over multiple inputs, I use SCOPED_TRACE, to show
which of the inputs caused the actual failure.
- for comparisons of vectors, I use gmock's container matchers, which
will print out the full container contents (and the elements that
differ) when they fail to match.
Reviewers: zturner, espindola
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D45941
llvm-svn: 330691
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test')
0 files changed, 0 insertions, 0 deletions