diff options
author | Michael Buch <michaelbuch12@gmail.com> | 2025-06-24 11:33:00 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-06-24 11:33:00 +0100 |
commit | 371f12f96dc0ba146a66dfb1c30198bf8555893e (patch) | |
tree | 1bf23865db544f5c0ec50bc01c19b92b3e30088d /lldb/packages/Python/lldbsuite/test | |
parent | 61b99ca51282f8ebe31c0a4c179383883730b8c7 (diff) | |
download | llvm-371f12f96dc0ba146a66dfb1c30198bf8555893e.zip llvm-371f12f96dc0ba146a66dfb1c30198bf8555893e.tar.gz llvm-371f12f96dc0ba146a66dfb1c30198bf8555893e.tar.bz2 |
Revert "[lldb] Add count for number of DWO files loaded in statistics" (#145494)
Reverts llvm/llvm-project#144424
Caused CI failures.
macOS CI failure was:
```
10:20:36 FAIL: test_dwp_dwo_file_count (TestStats.TestCase)
10:20:36 Test "statistics dump" and the loaded dwo file count.
10:20:36 ----------------------------------------------------------------------
10:20:36 Traceback (most recent call last):
10:20:36 File "/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/test/API/commands/statistics/basic/TestStats.py", line 639, in test_dwp_dwo_file_count
10:20:36 self.assertEqual(debug_stats["totalDwoFileCount"], 2)
10:20:36 AssertionError: 0 != 2
10:20:36 Config=arm64-/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/lldb-build/bin/clang
10:20:36 ======================================================================
10:20:36 FAIL: test_no_debug_names_eager_loads_dwo_files (TestStats.TestCase)
10:20:36 Test the eager loading behavior of DWO files when debug_names is absent by
10:20:36 ----------------------------------------------------------------------
10:20:36 Traceback (most recent call last):
10:20:36 File "/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/test/API/commands/statistics/basic/TestStats.py", line 566, in test_no_debug_names_eager_loads_dwo_files
10:20:36 self.assertEqual(debug_stats["totalDwoFileCount"], 2)
10:20:36 AssertionError: 0 != 2
10:20:36 Config=arm64-/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/lldb-build/bin/clang
10:20:36 ======================================================================
10:20:36 FAIL: test_split_dwarf_dwo_file_count (TestStats.TestCase)
10:20:36 Test "statistics dump" and the dwo file count.
10:20:36 ----------------------------------------------------------------------
10:20:36 Traceback (most recent call last):
10:20:36 File "/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/test/API/commands/statistics/basic/TestStats.py", line 588, in test_split_dwarf_dwo_file_count
10:20:36 self.assertEqual(len(debug_stats["modules"]), 1)
10:20:36 AssertionError: 42 != 1
10:20:36 Config=arm64-/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/lldb-build/bin/clang
```
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test')
-rw-r--r-- | lldb/packages/Python/lldbsuite/test/builders/builder.py | 26 | ||||
-rw-r--r-- | lldb/packages/Python/lldbsuite/test/make/Makefile.rules | 4 |
2 files changed, 7 insertions, 23 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/builders/builder.py b/lldb/packages/Python/lldbsuite/test/builders/builder.py index efb1ba5..de05732 100644 --- a/lldb/packages/Python/lldbsuite/test/builders/builder.py +++ b/lldb/packages/Python/lldbsuite/test/builders/builder.py @@ -247,25 +247,13 @@ class Builder: def _getDebugInfoArgs(self, debug_info): if debug_info is None: return [] - - debug_options = debug_info if isinstance(debug_info, list) else [debug_info] - option_flags = { - "dwarf": {"MAKE_DSYM": "NO"}, - "dwo": {"MAKE_DSYM": "NO", "MAKE_DWO": "YES"}, - "gmodules": {"MAKE_DSYM": "NO", "MAKE_GMODULES": "YES"}, - "debug_names": {"MAKE_DEBUG_NAMES": "YES"}, - "dwp": {"MAKE_DSYM": "NO", "MAKE_DWP": "YES"}, - } - - # Collect all flags, with later options overriding earlier ones - flags = {} - - for option in debug_options: - if not option or option not in option_flags: - return None # Invalid options - flags.update(option_flags[option]) - - return [f"{key}={value}" for key, value in flags.items()] + if debug_info == "dwarf": + return ["MAKE_DSYM=NO"] + if debug_info == "dwo": + return ["MAKE_DSYM=NO", "MAKE_DWO=YES"] + if debug_info == "gmodules": + return ["MAKE_DSYM=NO", "MAKE_GMODULES=YES"] + return None def getBuildCommand( self, diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules index 58833e1..06959f2 100644 --- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules +++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules @@ -276,10 +276,6 @@ ifeq "$(MAKE_DWO)" "YES" CFLAGS += -gsplit-dwarf endif -ifeq "$(MAKE_DEBUG_NAMES)" "YES" - CFLAGS += -gpubnames -endif - ifeq "$(USE_PRIVATE_MODULE_CACHE)" "YES" THE_CLANG_MODULE_CACHE_DIR := $(BUILDDIR)/private-module-cache else |