[lldb] Don't overwrite the dynamic loader library path for "driver tests"

We have a handful of tests that build a driver which links against LLDB.
When running those binaries, we overwrite the dynamic loader library
path to point to the build directory's libs dir, presumably to make sure
we load LLDB from there.

This above becomes an issue when you have libc++ enabled and the driver
is linked against the system's libc++, but the dynamic loader flag
forces it to pick up libc++ from the libs dir.

We could try to make the logic for building the driver smarter and have
it pick up the just-built libc++ like we do for our test binaries, but I
don't think we need to overwrite the library path in the first place.
The build logic to build these drivers already takes care to set the
correct RPATH in the linker.

This patch removes the logic and simplifies the tests.

1 files changed, 0 insertions, 15 deletions

diff --git a/lldb/packages/Python/lldbsuite/test/lldbtest.py b/lldb/packages/Python/lldbsuite/test/lldbtest.py
index 018f2a0..4931521 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -1594,21 +1594,6 @@ class Base(unittest.TestCase):
             print(str(method) + ":", result, file=sbuf)
         return result
 
-    def getLLDBLibraryEnvVal(self):
-        """Returns the path that the OS-specific library search environment variable
-        (self.dylibPath) should be set to in order for a program to find the LLDB
-        library. If an environment variable named self.dylibPath is already set,
-        the new path is appended to it and returned.
-        """
-        existing_library_path = (
-            os.environ[self.dylibPath] if self.dylibPath in os.environ else None
-        )
-        if existing_library_path:
-            return "%s:%s" % (existing_library_path, configuration.lldb_libs_dir)
-        if sys.platform.startswith("darwin") and configuration.lldb_framework_path:
-            return configuration.lldb_framework_path
-        return configuration.lldb_libs_dir
-
     def getLibcPlusPlusLibs(self):
         if self.getPlatform() in ("freebsd", "linux", "netbsd", "openbsd"):
             return ["libc++.so.1"]