diff options
author | Walter Erquinigo <wallace@fb.com> | 2020-04-03 19:42:58 -0700 |
---|---|---|
committer | Walter Erquinigo <wallace@fb.com> | 2020-04-15 16:03:31 -0700 |
commit | da0e91fee614e8686f48db28e6507c8abe061fc2 (patch) | |
tree | c284d4903141f5be8abd10be458060af597a454c /lldb/packages/Python/lldbsuite/test/dotest.py | |
parent | 85247c1e898f88d65154b9a437b4bd83fcad8d52 (diff) | |
download | llvm-da0e91fee614e8686f48db28e6507c8abe061fc2.zip llvm-da0e91fee614e8686f48db28e6507c8abe061fc2.tar.gz llvm-da0e91fee614e8686f48db28e6507c8abe061fc2.tar.bz2 |
[intel-pt] Improve the way the test determines whether to run
Summary:
@labath raised a concern on the way I was skipping this test. I think that was
fair and I found a better way.
Now I'm skipping if the CMAKE flag LLDB_BUILD_INTEL_PT is false.
I added an enabled_plugins entry in the dotest configuration, which gets
set by lit or lldb-dotest. The only available plugin right now is
'intel-pt', but I imagine it will be useful in the future for other
kinds of plugins that get determined at configuration time. I didn't
want to add a new argument option --enable-intel-pt or something or the
sort, as it wouldn't be useful for other cases.
Reviewers: labath, clayborg
Subscribers: lldb-commits, labath
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D77452
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/dotest.py')
-rw-r--r-- | lldb/packages/Python/lldbsuite/test/dotest.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py index b5666ec..c4e4b61 100644 --- a/lldb/packages/Python/lldbsuite/test/dotest.py +++ b/lldb/packages/Python/lldbsuite/test/dotest.py @@ -467,6 +467,9 @@ def parseOptionsAndInitTestdirs(): if args.lldb_libs_dir: configuration.lldb_libs_dir = args.lldb_libs_dir + if args.enabled_plugins: + configuration.enabled_plugins = args.enabled_plugins + # Gather all the dirs passed on the command line. if len(args.args) > 0: configuration.testdirs = [os.path.realpath(os.path.abspath(x)) for x in args.args] |