diff options
| author | Dave Lee <davelee.com@gmail.com> | 2022-08-21 21:48:14 -0700 |
|---|---|---|
| committer | Dave Lee <davelee.com@gmail.com> | 2022-08-22 15:46:03 -0700 |
| commit | c21dfa9e4931a0a339813a5d384fc2eb0deee235 (patch) | |
| tree | 3587d59185364245ec86cf395cc0d0b429a62e63 /lldb/packages/Python/lldbsuite/test/configuration.py | |
| parent | b1f2e2664ef059be834806c37eab32248a9f396f (diff) | |
| download | llvm-c21dfa9e4931a0a339813a5d384fc2eb0deee235.zip llvm-c21dfa9e4931a0a339813a5d384fc2eb0deee235.tar.gz llvm-c21dfa9e4931a0a339813a5d384fc2eb0deee235.tar.bz2 | |
[lldb] Remove prefer-dynamic-value test override
Remove the test override of `target.prefer-dynamic-value`.
Previously, the lldb default was `no-dynamic-values`. In rG9aa7e8e9ffbe (in
2015), the default was changed to `no-run-target`, but at that time the tests
were changed to be run with `no-dynamic-value`. I don't know the reasons for
not changing the tests, perhaps to avoid determining which tests to change, and
what about them to change.
Because `no-run-target` is the lldb default, I think it makes sense to make it
the test default too. It puts the test config closer to what's used in
practice.
This change removes the `target.prefer-dynamic-value` override, and for those
tests that failed, they have been updated to explicitly use
`no-dynamic-values`. Future changes could update these tests to use dynamic
values too, or they can be left as is to exercise non-dynamic typing.
Differential Revision: https://reviews.llvm.org/D132382
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/configuration.py')
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/configuration.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/configuration.py b/lldb/packages/Python/lldbsuite/test/configuration.py index 5133ded..2a8d125 100644 --- a/lldb/packages/Python/lldbsuite/test/configuration.py +++ b/lldb/packages/Python/lldbsuite/test/configuration.py @@ -51,8 +51,7 @@ sdkroot = None dwarf_version = 0 # Any overridden settings. -# Always disable default dynamic types for testing purposes. -settings = [('target.prefer-dynamic-value', 'no-dynamic-values')] +settings = [] # Path to the FileCheck testing tool. Not optional. filecheck = None |