diff options
| author | Pavel Labath <pavel@labath.sk> | 2019-06-17 07:32:56 +0000 |
|---|---|---|
| committer | Pavel Labath <pavel@labath.sk> | 2019-06-17 07:32:56 +0000 |
| commit | a71ce4f1e8e187bba7a3db4ce9d583bf3e9e3127 (patch) | |
| tree | d4901c651835049594d09ae800f62909fabaa422 /lldb/packages/Python/lldbsuite/test/configuration.py | |
| parent | ee62c40eae93c180d29e94841fbeb280ee737d26 (diff) | |
| download | llvm-a71ce4f1e8e187bba7a3db4ce9d583bf3e9e3127.zip llvm-a71ce4f1e8e187bba7a3db4ce9d583bf3e9e3127.tar.gz llvm-a71ce4f1e8e187bba7a3db4ce9d583bf3e9e3127.tar.bz2 | |
DWARF: Avoid storing DIERefs in long-lived containers
Summary:
A user_id_t carries the same information as a DIERef, but it takes up
less space.
Furthermore, DIERef::operator<'s implementation is very
questionable, as it does not take the cu_offset and section fields into
account. Using just the die offset was correct in the days when all
debug info lived in a single section, but since we started supporting
DWO debug info, this was no longer true. The comparison operator could
be fixed, but it seems like using the user_id_t for these purposes is a
better idea overall.
I think this did not cause any bugs, because the only place the
comparison operator was used is in m_function_scope_qualified_name_map,
and this one is local to a dwo file, but I am not 100% sure of that.
Reviewers: clayborg, JDevlieghere
Subscribers: aprantl, lldb-commits
Differential Revision: https://reviews.llvm.org/D63322
llvm-svn: 363528
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/configuration.py')
0 files changed, 0 insertions, 0 deletions