diff options
| author | Paula Toth <paulatoth@google.com> | 2020-03-17 12:59:21 -0700 |
|---|---|---|
| committer | Paula Toth <paulatoth@google.com> | 2020-03-17 13:00:00 -0700 |
| commit | 17566573b2997e468cb4190c6853b1ebea125962 (patch) | |
| tree | 7b4413147928a8eb9b39397019c3ea53b3655fbf /lldb/packages/Python/lldbsuite/test/bench.py | |
| parent | 2bd1ca28c1f1ea4b865790a6299f71496652fd2d (diff) | |
| download | llvm-17566573b2997e468cb4190c6853b1ebea125962.zip llvm-17566573b2997e468cb4190c6853b1ebea125962.tar.gz llvm-17566573b2997e468cb4190c6853b1ebea125962.tar.bz2 | |
[libc] Resolve race condition in sub-process test runner.
Summary:
There seems to be a race condition between the pipe closing and the child process death. Likely these two events are not atomic on some versions of linux.
With the removal of `WNOHANG` we eliminate the race condition, however if the child closes the pipe intentionally then it could result in the test runner hanging. I find this situation less likely, where as I experience failures locally with this race condition rather consistently.
Reviewers: sivachandra, abrachet
Reviewed By: sivachandra, abrachet
Subscribers: MaskRay, jfb, tschuett, libc-commits
Tags: #libc-project
Differential Revision: https://reviews.llvm.org/D76267
Diffstat (limited to 'lldb/packages/Python/lldbsuite/test/bench.py')
0 files changed, 0 insertions, 0 deletions